Changeset 1436 for trunk/src/org/expeditee/importer/TextImporter.java

Timestamp:

11/05/19 16:16:11 (5 years ago)

Author:

bnemhaus

Message:

Added the ability to copy/paste recognised files (mostly images) into Expeditee. This functionality already existed when drag n dropping, but now also works when using copy/paste.

At this stage, recognised files get imported as a approapriate Text Item. For example, a image will create a @i Text Item and attach it to your cursor. Ideally this would be the image directly. Unfortunately, items attached to the cursor (FreeItems) are not currently parsed. This is something I will discuss with David as there are confounding issues to consider. For example: surrogates...

Attached to the bottom of this commit message are my current thoughts.

Also made it so when creating a @i through DND or Copy/Paste, that @i is as relative as possible. The users image directories setting is used to achieve this.

---

• FreeItems need to be parsed...we would need to deal with primaries/surrogates in them...
• Do we want FreeItems to be parsed? If I attach an item to my cursor and then enter surrogate mode, should it change?
• My gut says no. Both because it would be work, and also because it kind of feels like a free win if we do not.
• But we do want to replace @i with images etc. Therefore, we want an old style parse for FreeItems?

File:

• trunk/src/org/expeditee/importer/TextImporter.java (modified) (2 diffs)

trunk/src/org/expeditee/importer/TextImporter.java

@@ -40 +40 @@
         }
 
-        public Item importFile(final File f, Point location) throws IOException {
+        public Item importFile(final File f, Point location, boolean attachToFreeItems) throws IOException {
                 if (location == null || f == null) {
                         return null;
@@ -46 +46 @@
                 final String fullPath = f.getAbsolutePath();
 
-                final Text source = DragAndDropManager.importString(f.getPath(), location);
+                final Text source = DragAndDropManager.importString(f.getPath(), location, false);
 
                 // Create a frameCreator to write the text