Changeset 921 for trunk/src/org/expeditee/items/widgets

Timestamp:

09/02/14 17:34:42 (10 years ago)

Author:

jts21

Message:

Avoided JfxBrowser build error (caused by having to use internal APIs which can change), by using reflection to get the methods at runtime if they are present

File:

• trunk/src/org/expeditee/items/widgets/JfxBrowser.java (modified) (3 diffs)

trunk/src/org/expeditee/items/widgets/JfxBrowser.java

@@ -33 +33 @@
 import java.io.InputStreamReader;
 import java.lang.reflect.Field;
+import java.lang.reflect.Method;
 
 import javafx.animation.FadeTransition;
@@ -508 +509 @@
                                 @Override
                                 public void handle(MouseEvent e) {
-                                        TextFieldSkin skin = (TextFieldSkin) JfxBrowser.this._urlField.getSkin();
-                                        
                                         if (!JfxBrowser.this._urlField.isDisabled()) {
                         if (JfxBrowser.this._buttonDownId == MouseButton.MIDDLE || JfxBrowser.this._buttonDownId == MouseButton.SECONDARY) {
                             if (!(e.isControlDown() || e.isAltDown() || e.isShiftDown() || e.isMetaDown())) {
-                                skin.positionCaret(skin.getIndex(e), true);
+                                setCaretFromCoord(JfxBrowser.this._urlField, e);
                             }
                         }
@@ -1040 +1039 @@
         }
         
+        /**
+         * Get internal JavaFX methods via reflection at runtime.<br>
+         * These are internal API methods for converting mouse (pixel) position to caret (text) position.
+         * This is used because JavaFX does not appear to support this functionality in any public API.
+         * This class solves two problems:
+         *  - If the system we are compiling on does not have the method, it should still compile
+         *  - If the system we are running on does not have the method, it should still run
+         *    (just without the expeditee-like URL bar text selection)
+         * Unfortunately it will still fail if the internal API ever removes the TextFieldSkin or HitInfo classes,
+         * But that is unavoidable without a compile-time preprocessor or some greater hacks
+         */
+        private static final class kludges {
+                
+                private static Method getGetIndex() {
+                        try {
+                                return TextFieldSkin.class.getMethod("getIndex", MouseEvent.class);
+                        } catch(Exception e) {
+                                return null;
+                        }
+                }
+                private static Method getGetInsertionIndex() {
+                        try {
+                                return HitInfo.class.getMethod("getInsertionIndex");
+                        } catch(Exception e) {
+                                return null;
+                        }
+                }
+                private static Method getPositionCaret() {
+                        try {
+                                return TextFieldSkin.class.getMethod("positionCaret", HitInfo.class,  boolean.class);
+                        } catch(Exception e) {
+                                return null;
+                        }
+                }
+                
+                private static final Method getIndex = getGetIndex();
+                private static final Method getInsertionIndex = getGetInsertionIndex();
+                private static final Method positionCaret = getPositionCaret();
+                private static final boolean enabled = (getIndex != null && getInsertionIndex != null && positionCaret != null);
+        }
+        
+        /**
+         * Attempts to get the caret (text) position for a given pixel (MouseEvent) position
+         * 
+         * @param text The textfield to find the caret position for
+         * @param e The MouseEvent containing the coordinates to convert to caret position
+         * 
+         * @return The caret position if successful, otherwise the current caret position of the TextField.
+         */
         private int getCaretFromCoord(TextField text, MouseEvent e) {
-                TextFieldSkin skin = (TextFieldSkin) text.getSkin();
-                HitInfo hit = skin.getIndex(e);
-                return hit.getInsertionIndex();
+                if (kludges.enabled) {
+                        try {
+                                return (int) kludges.getInsertionIndex.invoke(kludges.getIndex.invoke(text.getSkin(), e));
+                        } catch (Exception ex) {
+                                ex.printStackTrace();
+                        }
+                }
+                return text.getCaretPosition();
+        }
+        
+        /**
+         * Attempts to set the caret (text) position from a given pixel (MouseEvent) position
+         * 
+         * @param text The textfield to set the caret position of
+         * @param e The MouseEvent containing the coordinates to convert to caret position
+         */
+        private void setCaretFromCoord(TextField text, MouseEvent e) {
+                if (kludges.enabled) {
+                        try {
+                                Object skin = text.getSkin();
+                                kludges.positionCaret.invoke(skin, kludges.getIndex.invoke(skin, e), true);
+                        } catch (Exception ex) {
+                                ex.printStackTrace();
+                        }
+                }
         }