Changeset 570 for trunk/src/org/expeditee/items/widgets

Timestamp:

12/04/13 17:52:41 (11 years ago)

Author:

jts21

Message:

Add settings package which uses reflection to allow changing settings without hard coding the code to change every setting.

• Currently only works for String/Int/Boolean/Double values
• Supports default values by looking for fields with the prefix 'default', and will reset unset values to their default if a default exists.
• For more complex settings (e.g. proxy settings), there is a "onParsed()" callback which can be used to run additional code, and (in the case of the password widget) parse abnormal items.
• Some of the settings code in FrameUtils.ParseProfile has already been commented out since it's handled by default with the new Settings package. The rest could be moved over to UserSettings.onParsed(). Given the number of settings that remain to be moved, it may be a good idea to add the possibility for setting-specific onParsed() callbacks (could be done quite easily, similarly to how default values are handled).

File:

• trunk/src/org/expeditee/items/widgets/JfxBrowser.java (modified) (2 diffs)

trunk/src/org/expeditee/items/widgets/JfxBrowser.java

@@ -28 +28 @@
 import org.expeditee.gui.FreeItems;
 import org.expeditee.gui.MessageBay;
-import org.expeditee.gui.UserSettings;
 import org.expeditee.io.WebParser;
 import org.expeditee.items.Item;
 import org.expeditee.items.Text;
 import org.expeditee.reflection.JavaFX;
+import org.expeditee.settings.network.NetworkSettings;
 
 /**
@@ -418 +418 @@
                                 (firstSpace != -1 && firstSpace < firstSQ)) {      // no '/' or '?'             -> search
                                 // make it a search
-                                actualURL = UserSettings.searchEngine + url;
+                                actualURL = NetworkSettings.searchEngine + url;
                         } else {
                                 // add the missing protocol