Changeset 837

Timestamp:

02/05/14 10:52:39 (10 years ago)

Author:

ngw8

Message:

JFXBrowser buttons are now disabled when they can't be used

File:

• trunk/src/org/expeditee/items/widgets/JfxBrowser.java (modified) (9 diffs)

trunk/src/org/expeditee/items/widgets/JfxBrowser.java

@@ -74 +74 @@
         private WebView _webView;
         private WebEngine _webEngine;
+        private Button _forwardButton;
+        private Button _backButton;
+        private Button _convertButton;
+
         private TextField _urlField;
         private ProgressBar _urlProgressBar;
@@ -161 +165 @@
                         horizontal.getStyleClass().add("custom-toolbar");
                         
-                        Button backButton = new Button("Back");
-                        backButton.setMinWidth(Button.USE_PREF_SIZE);
-                        backButton.setFocusTraversable(false);
-                        backButton.getStyleClass().add("first");
-
-                        Button forwardButton = new Button("Forward");
-                        forwardButton.setMinWidth(Button.USE_PREF_SIZE);
-                        forwardButton.setFocusTraversable(false);
-                        forwardButton.getStyleClass().add("last");
+                        this._backButton = new Button("Back");
+                        this._backButton.setMinWidth(Button.USE_PREF_SIZE);
+                        this._backButton.setFocusTraversable(false);
+                        this._backButton.getStyleClass().add("first");
+
+                        this._backButton.setDisable(true);
+
+                        this._forwardButton = new Button("Forward");
+                        this._forwardButton.setMinWidth(Button.USE_PREF_SIZE);
+                        this._forwardButton.setFocusTraversable(false);
+                        this._forwardButton.getStyleClass().add("last");
 
                         this._urlField = new TextField(url);
@@ -181 +187 @@
                         goButton.setFocusTraversable(false);
 
-                        Button convertButton = new Button("Convert");
-                        convertButton.setMinWidth(Button.USE_PREF_SIZE);
-                        convertButton.setFocusTraversable(false);
+                        this._convertButton = new Button("Convert");
+                        this._convertButton.setMinWidth(Button.USE_PREF_SIZE);
+                        this._convertButton.setFocusTraversable(false);
                                                 
                         this._urlProgressBar = new ProgressBar();               
@@ -192 +198 @@
                         urlbar.getChildren().addAll(_urlProgressBar, this._urlField);
                                                 
-                        horizontal.getChildren().addAll(backButton, forwardButton, urlbar, goButton, convertButton);
-
-                        HBox.setHgrow(backButton, Priority.NEVER);
-                        HBox.setHgrow(forwardButton, Priority.NEVER);
-                        HBox.setHgrow(convertButton, Priority.NEVER);
+                        horizontal.getChildren().addAll(this._backButton, this._forwardButton, urlbar, goButton, this._convertButton);
+
+                        HBox.setHgrow(this._backButton, Priority.NEVER);
+                        HBox.setHgrow(this._forwardButton, Priority.NEVER);
+                        HBox.setHgrow(this._convertButton, Priority.NEVER);
                         HBox.setHgrow(goButton, Priority.NEVER);
                         HBox.setHgrow(urlbar, Priority.ALWAYS);
                         
                         HBox.setMargin(goButton, new Insets(0, 5, 0, 0));
-                        HBox.setMargin(forwardButton, new Insets(0, 5, 0, 0));
+                        HBox.setMargin(this._forwardButton, new Insets(0, 5, 0, 0));
 
                         this._webView = new WebView();
@@ -260 +266 @@
                         });
                         
-                        backButton.setOnAction(new EventHandler<ActionEvent>() {
+                        this._backButton.setOnAction(new EventHandler<ActionEvent>() {
                                 @Override
                 public void handle(ActionEvent e) {
@@ -267 +273 @@
                         });
 
-                        forwardButton.setOnAction(new EventHandler<ActionEvent>() {
+                        _forwardButton.setOnAction(new EventHandler<ActionEvent>() {
                                 @Override
                 public void handle(ActionEvent e) {
@@ -282 +288 @@
                         });
                         
-                        convertButton.setOnAction(new EventHandler<ActionEvent>() {
+                        this._convertButton.setOnAction(new EventHandler<ActionEvent>() {
                                 @Override
                 public void handle(ActionEvent e) {
@@ -421 +427 @@
                                                 // Removing the style from the progress bar that causes it to hide
                                                 JfxBrowser.this._urlProgressBar.getStyleClass().remove("completed");
+
+                                                if (JfxBrowser.this._webEngine.getHistory().getCurrentIndex() + 1 >= JfxBrowser.this._webEngine.getHistory().getEntries().size()) {
+                                                        JfxBrowser.this._forwardButton.setDisable(true);
+                                                } else {
+                                                        JfxBrowser.this._forwardButton.setDisable(false);
+                                                }
+
+                                                // Unless the history is empty (i.e. this is the first page being loaded), enable the back button.
+                                                // The only time the back button should be disbaled is on the first page load (which this statement deals with)
+                                                // and if the user has just hit the back button taking them to the first page in the history (dealt with in the
+                                                // navigateBack method)
+                                                if (JfxBrowser.this._webEngine.getHistory().getEntries().size() > 0) {
+                                                        JfxBrowser.this._backButton.setDisable(false);
+                                                }
+
+                                                JfxBrowser.this._convertButton.setDisable(true);
+
                                                 break;
                                         case SUCCEEDED: // SUCCEEDED
                                                 MessageBay.displayMessage("Finished loading page");
                                                 JfxBrowser.this._urlProgressBar.getStyleClass().add("completed");
-                                                break;
+
                                         case CANCELLED: // CANCELLED
-                                                MessageBay.displayMessage("Cancelled loading page");
+                                                JfxBrowser.this._convertButton.setDisable(false);
                                                 break;
                                         case FAILED: // FAILED
@@ -569 +592 @@
         public void navigateBack() {
                 try {
-                Platform.runLater(new Runnable() {
-                        @Override
-                        public void run() {
-                                try {
-                                        JfxBrowser.this._webEngine.getHistory().go(-1);
-                                        FreeItems.getInstance().clear();
-                                } catch (IndexOutOfBoundsException e) {
-                                        MessageBay.displayMessage("Start of History");
-                                        }
-                        }
-                });
+                        Platform.runLater(new Runnable() {
+                                @Override
+                                public void run() {
+                                        try {
+                                                JfxBrowser.this._webEngine.getHistory().go(-1);
+
+                                                // Disable the back button if we're at the start of history
+                                                if (JfxBrowser.this._webEngine.getHistory().getCurrentIndex() <= 0) {
+                                                        JfxBrowser.this._backButton.setDisable(true);
+                                                } else {
+                                                        JfxBrowser.this._backButton.setDisable(false);
+                                                }
+
+                                                FreeItems.getInstance().clear();
+                                        } catch (IndexOutOfBoundsException e) {
+                                                MessageBay.displayMessage("Start of History");
+                                        }
+                                }
+                        });
                 } catch (Exception e) {
                         e.printStackTrace();