Changeset 1476 for trunk

Timestamp:

12/03/19 14:08:11 (4 years ago)

Author:

bnemhaus

Message:

Added feedback to ensure that when attempting to use AuthRegainAccountAccess you provide a username.
Yikes, there is currently no guarantee that you are changing the correct person's password. This needs to be fixed.

Location:

trunk/src/org/expeditee/auth

Files:

• Actions.java (modified) (1 diff)
• account/Password.java (modified) (1 diff)

trunk/src/org/expeditee/auth/Actions.java

@@ -301 +301 @@
                         // Confirm new requested passwords match
                         Map<AuthenticationTag, String> userData = userdata.get();
-                        if (!userData.get(AuthenticationTag.NewPassword).equals(userData.get(AuthenticationTag.NewPasswordAgain))) {
+                        String username = userData.get(AuthenticationTag.Username).trim();
+                        if (username.length() == 0) {
+                                MessageBay.errorMessage("Please fill out the username box.");
+                        } else if (!userData.get(AuthenticationTag.NewPassword).equals(userData.get(AuthenticationTag.NewPasswordAgain))) {
                                 MessageBay.errorMessage("The passwords you have provided do not match.");
-                                return;
-                        }
-                        
-                        Password.regainAccountAccess(userData);
+                        } else {
+                                Password.regainAccountAccess(userData);
+                        }
                 }
         }

trunk/src/org/expeditee/auth/account/Password.java

@@ -350 +350 @@
                 
                 try {
+                        // TODO: YIKES!  We can currently change anyone's password!
                         AuthenticatorBrowser.getInstance().putKey(userData.get(AuthenticationTag.Username), userData.get(AuthenticationTag.NewPassword), new SecretKeySpec(join, SymmetricAlgorithm));
                 } catch (KeyStoreException | NoSuchAlgorithmException | CertificateException | ClassNotFoundException