Changeset 1342 for trunk

Timestamp:

05/02/19 12:53:08 (5 years ago)

Author:

bln4

Message:

Following investigation I have figured out why the version zero check stops version conflicts from happenings. Here, and as a comment in the code, I have explained the details.

Q: Why do we ignore version conflicts if the saved version is zero?
A: Sometimes a Frame object in memory with a specified path is not 'connected'

to the file found at that specified path yet. This occurs if a frame object
has been created, its path assigned and saved to disk; with the intention
discarding this Frame object and later saving a different Frame object to
that File. One example of this is when @old frames are created.
The new Frame object that is created and saved only to be discarded, has a
version number of zero.
Therefore, if the file created from the discarded Frame has its modification
date compared to the modification date on the Frame object that will eventually
be used to overwrite that file, it causes a false positive conflict. Checking
for the zero version number fixes this.

File:

• trunk/src/org/expeditee/gui/FrameIO.java (modified) (3 diffs)

trunk/src/org/expeditee/gui/FrameIO.java

@@ -1022 +1022 @@
 
         public static void DisableCache() {
+                System.err.println(" --------- Cache Disabled --------- ");
                 _UseCache = false;
         }
 
         public static void EnableCache() {
+                System.err.println(" --------- Cache Enabled --------- ");
                 _UseCache = true;
         }
 
         public static void SuspendCache() {
+                System.err.println("SuspendCache: _UseCache" + " was " + _UseCache);
                 if (_UseCache) {
                         DisableCache();
@@ -1036 +1039 @@
                         _SuspendedCache = false;
                 }
+                System.err.println("   Cache is suspended -> " + _SuspendedCache);
+                System.err.println("   _UseCache is -> " + _UseCache);
+                System.err.println();
         }
 
         public static void ResumeCache() {
+                System.err.println("ResumeCache: _UseCache" + " was " + _UseCache);
                 if (_SuspendedCache) {
                         EnableCache();
                         _SuspendedCache = false;
                 }
+                System.err.println("   Cache is suspended -> " + _SuspendedCache);
+                System.err.println("   _UseCache is -> " + _UseCache);
+                System.err.println();
         }
 
@@ -1227 +1237 @@
 
                         // Check if we are trying to save an out of date version
+                        // Q:   Why do we ignore version conflicts if the saved version is zero?
+                        // A:   Sometimes a Frame object in memory with a specified path is not 'connected' 
+                        //              to the file found at that specified path yet.  This occurs if a frame object
+                        //              has been created, its path assigned and saved to disk; with the intention 
+                        //              discarding this Frame object and later saving a different Frame object to 
+                        //              that File.  One example of this is when @old frames are created.
+                        //              The new Frame object that is created and saved only to be discarded, has a
+                        //              version number of zero.  
+                        //              Therefore, if the file created from the discarded Frame has its modification
+                        //              date compared to the modification date on the Frame object that will eventually
+                        //              be used to overwrite that file, it causes a false positive conflict.  Checking
+                        //              for the zero version number fixes this.
                         String framesetName = toSave.getFramesetName();
                         boolean isBayFrameset =